Refactor

DiscordChatExporter.Cli/Commands/Base/ExportCommandBase.cs

@@ -11,28 +11,36 @@ namespace DiscordChatExporter.Cli.Commands.Base
 {
     public abstract class ExportCommandBase : TokenCommandBase
     {
-        [CommandOption("output", 'o', Description = "Output file or directory path.")]
+        [CommandOption("output", 'o',
+            Description = "Output file or directory path.")]
         public string OutputPath { get; set; } = Directory.GetCurrentDirectory();
 
-        [CommandOption("format", 'f', Description = "Output file format.")]
+        [CommandOption("format", 'f',
+            Description = "Export format.")]
         public ExportFormat ExportFormat { get; set; } = ExportFormat.HtmlDark;
 
-        [CommandOption("after", Description = "Limit to messages sent after this date.")]
+        [CommandOption("after",
+            Description = "Only include messages sent after this date.")]
         public DateTimeOffset? After { get; set; }
 
-        [CommandOption("before", Description = "Limit to messages sent before this date.")]
+        [CommandOption("before",
+            Description = "Only include messages sent before this date.")]
         public DateTimeOffset? Before { get; set; }
 
-        [CommandOption("partition", 'p', Description = "Split output into partitions limited to this number of messages.")]
+        [CommandOption("partition", 'p',
+            Description = "Split output into partitions limited to this number of messages.")]
         public int? PartitionLimit { get; set; }
 
-        [CommandOption("media", Description = "Download referenced media content.")]
+        [CommandOption("media",
+            Description = "Download referenced media content.")]
         public bool ShouldDownloadMedia { get; set; }
 
-        [CommandOption("reuse-media", Description = "If the media folder already exists, reuse media inside it to skip downloads.")]
+        [CommandOption("reuse-media",
+            Description = "Reuse already existing media content to skip redundant downloads.")]
         public bool ShouldReuseMedia { get; set; }
 
-        [CommandOption("dateformat", Description = "Date format used in output.")]
+        [CommandOption("dateformat",
+            Description = "Format used when writing dates.")]
         public string DateFormat { get; set; } = "dd-MMM-yy hh:mm tt";
 
         protected ChannelExporter GetChannelExporter() => new ChannelExporter(GetDiscordClient());

DiscordChatExporter.Cli/Commands/Base/ExportMultipleCommandBase.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System.Collections.Concurrent;
+using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
@@ -16,21 +17,23 @@ namespace DiscordChatExporter.Cli.Commands.Base
 {
     public abstract class ExportMultipleCommandBase : ExportCommandBase
     {
-        [CommandOption("parallel", Description = "Export this number of channels in parallel.")]
+        [CommandOption("parallel",
+            Description = "Limits how many channels can be exported in parallel.")]
         public int ParallelLimit { get; set; } = 1;
 
         protected async ValueTask ExportMultipleAsync(IConsole console, IReadOnlyList<Channel> channels)
         {
-            // HACK: this uses a separate route from ExportCommandBase because the progress ticker is not thread-safe
+            // This uses a different route from ExportCommandBase.ExportAsync() because it runs
+            // in parallel and needs another way to report progress to console.
 
             console.Output.Write($"Exporting {channels.Count} channels... ");
             var progress = console.CreateProgressTicker();
 
             var operations = progress.Wrap().CreateOperations(channels.Count);
 
-            var errors = new List<string>();
-
             var successfulExportCount = 0;
+            var errors = new ConcurrentBag<string>();
+
             await channels.Zip(operations).ParallelForEachAsync(async tuple =>
             {
                 var (channel, operation) = tuple;

DiscordChatExporter.Cli/Commands/Base/TokenCommandBase.cs

@@ -7,15 +7,22 @@ namespace DiscordChatExporter.Cli.Commands.Base
 {
     public abstract class TokenCommandBase : ICommand
     {
-        [CommandOption("token", 't', IsRequired = true, EnvironmentVariableName = "DISCORD_TOKEN",
+        [CommandOption("token", 't', IsRequired = true,
+            EnvironmentVariableName = "DISCORD_TOKEN",
             Description = "Authorization token.")]
         public string TokenValue { get; set; } = "";
 
-        [CommandOption("bot", 'b', EnvironmentVariableName = "DISCORD_TOKEN_BOT",
-            Description = "Whether this authorization token belongs to a bot.")]
+        [CommandOption("bot", 'b',
+            EnvironmentVariableName = "DISCORD_TOKEN_BOT",
+            Description = "Authorize as a bot.")]
         public bool IsBotToken { get; set; }
 
-        protected AuthToken GetAuthToken() => new AuthToken(IsBotToken ? AuthTokenType.Bot : AuthTokenType.User, TokenValue);
+        protected AuthToken GetAuthToken() => new AuthToken(
+            IsBotToken
+                ? AuthTokenType.Bot
+                : AuthTokenType.User,
+            TokenValue
+        );
 
         protected DiscordClient GetDiscordClient() => new DiscordClient(GetAuthToken());