From 2f241574fd3a76b331ceef32590025b2878bff92 Mon Sep 17 00:00:00 2001
From: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
Date: Wed, 12 Aug 2026 23:31:29 -0700
Subject: [PATCH] fix(ui): fix shift opacity not targeting correct widget

---
 src/tagstudio/qt/controllers/suggest_box.py | 23 +++++++++------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/src/tagstudio/qt/controllers/suggest_box.py b/src/tagstudio/qt/controllers/suggest_box.py
index 575f508a..c82d33f9 100644
--- a/src/tagstudio/qt/controllers/suggest_box.py
+++ b/src/tagstudio/qt/controllers/suggest_box.py
@@ -85,19 +85,17 @@ class SuggestBox[T](QWidget):
         self.layout().search_field.index_updated.connect(partial(self._on_index_updated))
 
     def _on_shift_held(self, held: bool) -> None:
-        if held:
-            self._is_shift_held = True
-            opacity_effect = QGraphicsOpacityEffect(self)
-            opacity_effect.setOpacity(0.3)
-            if self.layout().content_layout.count() > 0:
-                underlined_widget = self.layout().content_layout.itemAt(0).widget()
-                assert isinstance(underlined_widget, UnderlinedWidget)
+        for i in range(0, self.layout().content_layout.count()):
+            underlined_widget = self.layout().content_layout.itemAt(i).widget()
+            assert isinstance(underlined_widget, UnderlinedWidget)
+
+            if held and i == self._selection_index:
+                self._is_shift_held = True
+                opacity_effect = QGraphicsOpacityEffect(self)
+                opacity_effect.setOpacity(0.3)
                 underlined_widget.widget.setGraphicsEffect(opacity_effect)
-        else:
-            self._is_shift_held = False
-            if self.layout().content_layout.count() > 0:
-                underlined_widget = self.layout().content_layout.itemAt(0).widget()
-                assert isinstance(underlined_widget, UnderlinedWidget)
+            else:
+                self._is_shift_held = False
                 underlined_widget.widget.setGraphicsEffect(None)  # pyright: ignore[reportArgumentType]
 
     def _on_index_updated(self, delta: int) -> None:
@@ -118,7 +116,6 @@ class SuggestBox[T](QWidget):
             self._selection_index = max_idx
         else:
             self._selection_index = self._selection_index + delta
-        logger.info(self._selection_index)
 
         # Don't update the UI if there's no index change
         if old_idx == self._selection_index: