From a7b6636a0b3629e2d3ceb4fc6f2a1c3ac4260c4e Mon Sep 17 00:00:00 2001 From: Jann Stute <46534683+Computerdores@users.noreply.github.com> Date: Wed, 13 May 2026 08:28:24 +0200 Subject: [PATCH] fix: pyright errors in ts_qt.py (#1237) --- src/tagstudio/qt/ts_qt.py | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/tagstudio/qt/ts_qt.py b/src/tagstudio/qt/ts_qt.py index 7baae6d3..06d9ebb0 100644 --- a/src/tagstudio/qt/ts_qt.py +++ b/src/tagstudio/qt/ts_qt.py @@ -8,7 +8,6 @@ """A Qt driver for TagStudio.""" -import contextlib import ctypes import math import os @@ -194,7 +193,7 @@ class QtDriver(DriverMixin, QObject): applied_theme: Theme lib: Library - cache_manager: CacheManager + cache_manager: CacheManager | None browsing_history: History[BrowsingState] @@ -539,7 +538,7 @@ class QtDriver(DriverMixin, QObject): # TODO: Move this to a settings screen. self.main_window.menu_bar.clear_thumb_cache_action.triggered.connect( - lambda: self.cache_manager.clear_cache() + lambda: unwrap(self.cache_manager).clear_cache() ) # endregion @@ -913,7 +912,7 @@ class QtDriver(DriverMixin, QObject): origin_id(id): The entry ID associated with the widget making the call. """ entry: Entry | None = None - pending: list[tuple[int, Path]] = [] + pending: list[tuple[int | None, Path]] = [] deleted_count: int = 0 selected = self.selected @@ -921,14 +920,13 @@ class QtDriver(DriverMixin, QObject): if len(selected) <= 1 and origin_path: origin_id_ = origin_id - if not origin_id_: - with contextlib.suppress(IndexError): - origin_id_ = selected[0] + if origin_id_ is None: + origin_id_ = selected[0] if len(selected) > 0 else None pending.append((origin_id_, Path(origin_path))) else: for item in selected: - entry = self.lib.get_entry(item) + entry = unwrap(self.lib.get_entry(item)) filepath: Path = entry.path pending.append((item, filepath)) @@ -950,7 +948,8 @@ class QtDriver(DriverMixin, QObject): self.main_window.status_bar.showMessage(msg) self.main_window.status_bar.repaint() - self.lib.remove_entries([e_id]) + if e_id is not None: + self.lib.remove_entries([e_id]) if delete_file(library_dir / f): deleted_count += 1 @@ -1226,10 +1225,10 @@ class QtDriver(DriverMixin, QObject): for field in self.copy_buffer["fields"]: exists = False for e in existing_fields: - if field.type_key == e.type_key and field.value == e.value: + if field == e: exists = True if not exists: - self.lib.add_field_to_entries(id, field_id=field.type_key, value=field.value) + self.lib.add_field_to_entries(id, field=field) self.lib.add_tags_to_entries(id, self.copy_buffer["tags"]) if len(self.selected) > 1: if TAG_ARCHIVED in self.copy_buffer["tags"]: