From 122053939d75028e4ac4c8924f130894819d739c Mon Sep 17 00:00:00 2001 From: miloschwartz Date: Mon, 9 Feb 2026 14:41:40 -0800 Subject: [PATCH] dont fingerprint machine clients --- server/routers/client/getClient.ts | 4 +++- server/routers/client/listClients.ts | 5 ++++- server/routers/olm/handleOlmPingMessage.ts | 6 +++++- server/routers/olm/handleOlmRegisterMessage.ts | 6 +++++- 4 files changed, 17 insertions(+), 4 deletions(-) diff --git a/server/routers/client/getClient.ts b/server/routers/client/getClient.ts index 12901d0c..b8b5594e 100644 --- a/server/routers/client/getClient.ts +++ b/server/routers/client/getClient.ts @@ -294,9 +294,11 @@ export async function getClient( ); } + const isUserDevice = client.user !== null && client.user !== undefined; + // Replace name with device name if OLM exists let clientName = client.clients.name; - if (client.olms) { + if (client.olms && isUserDevice) { const model = client.currentFingerprint?.deviceModel || null; clientName = getUserDeviceName(model, client.clients.name); } diff --git a/server/routers/client/listClients.ts b/server/routers/client/listClients.ts index b4e2eb56..09560c6d 100644 --- a/server/routers/client/listClients.ts +++ b/server/routers/client/listClients.ts @@ -320,7 +320,10 @@ export async function listClients( // Merge clients with their site associations and replace name with device name const clientsWithSites = clientsList.map((client) => { const model = client.deviceModel || null; - const newName = getUserDeviceName(model, client.name); + let newName = client.name; + if (filter === "user") { + newName = getUserDeviceName(model, client.name); + } return { ...client, name: newName, diff --git a/server/routers/olm/handleOlmPingMessage.ts b/server/routers/olm/handleOlmPingMessage.ts index b87f49d2..efcbf169 100644 --- a/server/routers/olm/handleOlmPingMessage.ts +++ b/server/routers/olm/handleOlmPingMessage.ts @@ -117,6 +117,8 @@ export const handleOlmPingMessage: MessageHandler = async (context) => { return; } + const isUserDevice = olm.userId !== null && olm.userId !== undefined; + try { // get the client const [client] = await db @@ -219,7 +221,9 @@ export const handleOlmPingMessage: MessageHandler = async (context) => { logger.error("Error handling ping message", { error }); } - await handleFingerprintInsertion(olm, fingerprint, postures); + if (isUserDevice) { + await handleFingerprintInsertion(olm, fingerprint, postures); + } return { message: { diff --git a/server/routers/olm/handleOlmRegisterMessage.ts b/server/routers/olm/handleOlmRegisterMessage.ts index e4bb6f4f..7fa43c9c 100644 --- a/server/routers/olm/handleOlmRegisterMessage.ts +++ b/server/routers/olm/handleOlmRegisterMessage.ts @@ -53,7 +53,11 @@ export const handleOlmRegisterMessage: MessageHandler = async (context) => { postures }); - await handleFingerprintInsertion(olm, fingerprint, postures); + const isUserDevice = olm.userId !== null && olm.userId !== undefined; + + if (isUserDevice) { + await handleFingerprintInsertion(olm, fingerprint, postures); + } if ( (olmVersion && olm.version !== olmVersion) ||