calvin.erfmann/pangolin
1
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-06-23 07:41:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

♻️ Remove queries that prefetch 1000 users/roles in private resources form

Browse Source
This commit is contained in:
Fred KISSIE
2026-06-09 19:29:00 +02:00
parent 407ba567a0
commit 38203e522b
1 changed files with 3 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/components/PrivateResourceForm.tsx
View File

@@ -411,9 +411,9 @@ export function PrivateResourceForm({
type FormData = z.infer<typeof formSchema>; type FormData = z.infer<typeof formSchema>;
const rolesQuery = useQuery(orgQueries.roles({ orgId })); const clientsQuery = useQuery(
const usersQuery = useQuery(orgQueries.users({ orgId })); orgQueries.machineClients({ orgId, perPage: 1 })
const clientsQuery = useQuery(orgQueries.machineClients({ orgId })); );
const resourceRolesQuery = useQuery({ const resourceRolesQuery = useQuery({
...resourceQueries.siteResourceRoles({ ...resourceQueries.siteResourceRoles({
siteResourceId: siteResourceId ?? 0 siteResourceId: siteResourceId ?? 0
@@ -433,13 +433,6 @@ export function PrivateResourceForm({
enabled: siteResourceId != null enabled: siteResourceId != null
}); });
const allRoles = (rolesQuery.data ?? [])
.map((r) => ({ id: r.roleId.toString(), text: r.name }))
.filter((r) => r.text !== "Admin");
const allUsers = (usersQuery.data ?? []).map((u) => ({
id: u.id.toString(),
text: `${getUserDisplayName({ email: u.email, username: u.username })}${u.type !== UserType.Internal ? ` (${u.idpName})` : ""}`
}));
const allClients = (clientsQuery.data ?? []) const allClients = (clientsQuery.data ?? [])
.filter((c) => !c.userId) .filter((c) => !c.userId)
.map((c) => ({ id: c.clientId.toString(), text: c.name })); .map((c) => ({ id: c.clientId.toString(), text: c.name }));
@@ -478,8 +471,6 @@ export function PrivateResourceForm({
} }
const loadingRolesUsers = const loadingRolesUsers =
rolesQuery.isLoading ||
usersQuery.isLoading ||
clientsQuery.isLoading || clientsQuery.isLoading ||
(siteResourceId != null && (siteResourceId != null &&
(resourceRolesQuery.isLoading || (resourceRolesQuery.isLoading ||
@@ -488,16 +479,6 @@ export function PrivateResourceForm({
const hasMachineClients = allClients.length > 0; const hasMachineClients = allClients.length > 0;
const [activeRolesTagIndex, setActiveRolesTagIndex] = useState<
number | null
>(null);
const [activeUsersTagIndex, setActiveUsersTagIndex] = useState<
number | null
>(null);
const [activeClientsTagIndex, setActiveClientsTagIndex] = useState<
number | null
>(null);
const [sshServerMode, setSshServerMode] = useState<"standard" | "native">( const [sshServerMode, setSshServerMode] = useState<"standard" | "native">(
() => { () => {
if (variant === "edit" && resource) { if (variant === "edit" && resource) {