From 47be3dbdf957fcdbe11e09c39cdf72d309e4183a Mon Sep 17 00:00:00 2001
From: miloschwartz <mschwartz10612@gmail.com>
Date: Mon, 20 Apr 2026 17:06:56 -0700
Subject: [PATCH] hide add idp button when no mode set

---
 src/components/IdpGlobalModeBanner.tsx | 16 +++++++++-------
 src/components/OrgIdpDataTable.tsx     |  5 ++++-
 src/components/OrgIdpTable.tsx         |  6 +++++-
 3 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/src/components/IdpGlobalModeBanner.tsx b/src/components/IdpGlobalModeBanner.tsx
index 9f864b36d..5e2709e6f 100644
--- a/src/components/IdpGlobalModeBanner.tsx
+++ b/src/components/IdpGlobalModeBanner.tsx
@@ -8,23 +8,25 @@ import { useEnvContext } from "@app/hooks/useEnvContext";
 import { usePaidStatus } from "@app/hooks/usePaidStatus";
 import { tierMatrix } from "@server/lib/billing/tierMatrix";
 import { build } from "@server/build";
+import type { Env } from "@app/lib/types/env";
+
+export function isIdpGlobalModeBannerVisible(env: Env): boolean {
+    if (build === "saas") {
+        return false;
+    }
+    return env.app.identityProviderMode === undefined;
+}
 
 export function IdpGlobalModeBanner() {
     const t = useTranslations();
     const { env } = useEnvContext();
     const { isPaidUser, hasEnterpriseLicense } = usePaidStatus();
 
-    const identityProviderModeUndefined =
-        env.app.identityProviderMode === undefined;
     const paidUserForOrgOidc = isPaidUser(tierMatrix.orgOidc);
     const enterpriseUnlicensed =
         build === "enterprise" && !hasEnterpriseLicense;
 
-    if (build === "saas") {
-        return null;
-    }
-
-    if (!identityProviderModeUndefined) {
+    if (!isIdpGlobalModeBannerVisible(env)) {
         return null;
     }
 
diff --git a/src/components/OrgIdpDataTable.tsx b/src/components/OrgIdpDataTable.tsx
index 7e3f7ab65..fe15b6cc9 100644
--- a/src/components/OrgIdpDataTable.tsx
+++ b/src/components/OrgIdpDataTable.tsx
@@ -12,13 +12,15 @@ interface DataTableProps<TData, TValue> {
     data: TData[];
     onAdd?: () => void;
     addActions?: DataTableAddAction[];
+    addButtonDisabled?: boolean;
 }
 
 export function IdpDataTable<TData, TValue>({
     columns,
     data,
     onAdd,
-    addActions
+    addActions,
+    addButtonDisabled
 }: DataTableProps<TData, TValue>) {
     const t = useTranslations();
 
@@ -33,6 +35,7 @@ export function IdpDataTable<TData, TValue>({
             addButtonText={t("idpAdd")}
             onAdd={onAdd}
             addActions={addActions}
+            addButtonDisabled={addButtonDisabled}
             enableColumnVisibility={true}
             stickyRightColumn="actions"
         />
diff --git a/src/components/OrgIdpTable.tsx b/src/components/OrgIdpTable.tsx
index 0e3a83dc2..1fe61b2fc 100644
--- a/src/components/OrgIdpTable.tsx
+++ b/src/components/OrgIdpTable.tsx
@@ -52,6 +52,7 @@ import type { ListUserAdminOrgIdpsResponse } from "@server/routers/orgIdp/types"
 import { cn } from "@app/lib/cn";
 import { usePaidStatus } from "@app/hooks/usePaidStatus";
 import { tierMatrix } from "@server/lib/billing/tierMatrix";
+import { isIdpGlobalModeBannerVisible } from "@app/components/IdpGlobalModeBanner";
 
 export type IdpRow = {
     idpId: number;
@@ -85,13 +86,15 @@ export default function IdpTable({ idps, orgId }: Props) {
     const [importSubmitting, setImportSubmitting] = useState(false);
     const [debouncedImportSearch] = useDebounce(importSearchQuery, 150);
 
-    const api = createApiClient(useEnvContext());
+    const envContext = useEnvContext();
+    const api = createApiClient(envContext);
     const { user } = useUserContext();
     const { isPaidUser } = usePaidStatus();
     const router = useRouter();
     const t = useTranslations();
 
     const canImportOrgOidcIdp = isPaidUser(tierMatrix.orgOidc);
+    const addIdpDisabled = isIdpGlobalModeBannerVisible(envContext.env);
 
     const { data: adminIdpsRaw = [] } = useQuery({
         queryKey: ["admin-org-idps", user.userId],
@@ -427,6 +430,7 @@ export default function IdpTable({ idps, orgId }: Props) {
             <IdpDataTable
                 columns={columns}
                 data={idps}
+                addButtonDisabled={addIdpDisabled}
                 addActions={[
                     {
                         label: t("idpAddActionCreateNew"),