🐛 handle idempotency when adding/removing labels from sites/resources

2026-05-26 02:32:36 +00:00 · 2026-05-11 16:57:53 +02:00
parent 2fd519e102
commit b9ab35a05b
2 changed files with 44 additions and 31 deletions
--- a/server/private/routers/labels/attachLabelToItem.ts
+++ b/server/private/routers/labels/attachLabelToItem.ts
@@ -106,13 +106,14 @@ export async function attachLabelToItem(
                );
            }

+            // idempotent, calling this endpoint multiple times should attach the label only once
            await db
                .insert(siteLabels)
                .values({
                    labelId,
                    siteId
                })
-                .returning();
+                .onConflictDoNothing();
        }

        if (resourceId) {
@@ -133,10 +134,14 @@ export async function attachLabelToItem(
                );
            }

-            await db.insert(resourceLabels).values({
-                labelId,
-                resourceId
-            });
+            // idempotent, calling this endpoint multiple times should attach the label only once
+            await db
+                .insert(resourceLabels)
+                .values({
+                    labelId,
+                    resourceId
+                })
+                .onConflictDoNothing();
        }

        return response(res, {