calvin.erfmann/pangolin
1
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-09-16 15:50:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): harden app-readiness PID check; clarify version-source comment

Browse Source 
Address review feedback on the readiness step:
- Read the PID safely (`cat app.pid 2>/dev/null || true`) and treat a
  missing/empty PID as "not running", so a failed nohup no longer produces a
  confusing `kill` usage error and misleading message.
- Guard the diagnostic dump behind a helper so a missing app.log prints
  "(app.log not found)" instead of erroring.
- The exact 24.18.1 pin comes from the Dockerfiles; .nvmrc only pins the 24
  major. Corrected the comments to say so rather than citing .nvmrc as the
  source of the patch version.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Parikshith
2026-09-08 16:28:35 +05:30
parent 938d7f145c
commit c19cb706e8
2 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/linting.yml
+3 -2
View File
@@ -26,8 +26,9 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
# Match the version the app ships on (Dockerfile / .nvmrc)
# rather than floating to the latest 24.x.
# Match the version the app ships on (Dockerfile /
# Dockerfile.dev both use 24.18.1) rather than floating
# to the latest 24.x.
node-version: '24.18.1'
- name: Install dependencies