Merge pull request #3350 from fosrl/dev

Make sure the rebuild actually executes

server/lib/calculateUserClientsForOrgs.ts

@@ -29,7 +29,7 @@ type ClientRow = typeof clients.$inferSelect;
 function runQueuedClientAssociationRebuilds(
     userId: string,
     queuedClients: ClientRow[]
-): void {
+) {
     if (queuedClients.length === 0) {
         return;
     }
@@ -39,35 +39,29 @@ function runQueuedClientAssociationRebuilds(
         uniqueClientsById.set(client.clientId, client);
     }
 
-    void (async () => {
     for (const client of uniqueClientsById.values()) {
-            try {
+        rebuildClientAssociationsFromClient(client).catch((error) => {
-                await rebuildClientAssociationsFromClient(client);
-            } catch (error) {
             logger.error(
-                    `Failed rebuilding associations for client ${client.clientId} (user ${userId}): ${String(error)}`
+                `Error rebuilding client associations for client ${client.clientId} (user ${userId}): ${String(
+                    error
+                )}`
             );
-            }
+        });
     }
 
     logger.debug(
         `Queued association rebuild completed for ${uniqueClientsById.size} client(s) (user ${userId})`
     );
-    })();
 }
 
 export async function calculateUserClientsForOrgs(
     userId: string
 ): Promise<void> {
     const trx = primaryDb;
-    const queuedAssociationRebuilds: ClientRow[] = [];
 
-    const execute = async (transaction: Transaction | typeof db) => {
+    const queuedAssociationRebuilds: ClientRow[] = [];
     const orgCache = new Map<string, typeof orgs.$inferSelect | null>();
-        const adminRoleCache = new Map<
+    const adminRoleCache = new Map<string, typeof roles.$inferSelect | null>();
-            string,
-            typeof roles.$inferSelect | null
-        >();
     const exitNodesCache = new Map<
         string,
         Awaited<ReturnType<typeof listExitNodes>>
@@ -80,8 +74,7 @@ export async function calculateUserClientsForOrgs(
     const roleClientAccessCache = new Map<string, boolean>();
     const userClientAccessCache = new Map<string, boolean>();
 
-        const getOrgOlmKey = (orgId: string, olmId: string) =>
+    const getOrgOlmKey = (orgId: string, olmId: string) => `${orgId}:${olmId}`;
-            `${orgId}:${olmId}`;
     const getRoleClientKey = (roleId: number, clientId: number) =>
         `${roleId}:${clientId}`;
     const getUserClientKey = (cachedUserId: string, clientId: number) =>
@@ -92,7 +85,7 @@ export async function calculateUserClientsForOrgs(
             return orgCache.get(orgId) ?? null;
         }
 
-            const [org] = await transaction
+        const [org] = await trx
             .select()
             .from(orgs)
             .where(eq(orgs.orgId, orgId));
@@ -106,7 +99,7 @@ export async function calculateUserClientsForOrgs(
             return adminRoleCache.get(orgId) ?? null;
         }
 
-            const [adminRole] = await transaction
+        const [adminRole] = await trx
             .select()
             .from(roles)
             .where(and(eq(roles.isAdmin, true), eq(roles.orgId, orgId)))
@@ -147,7 +140,7 @@ export async function calculateUserClientsForOrgs(
             return existingClientCache.get(key) ?? null;
         }
 
-            const [existingClient] = await transaction
+        const [existingClient] = await trx
             .select()
             .from(clients)
             .where(
@@ -164,16 +157,13 @@ export async function calculateUserClientsForOrgs(
         return existingClient ?? null;
     };
 
-        const hasRoleClientAccess = async (
+    const hasRoleClientAccess = async (roleId: number, clientId: number) => {
-            roleId: number,
-            clientId: number
-        ) => {
         const key = getRoleClientKey(roleId, clientId);
         if (roleClientAccessCache.has(key)) {
             return roleClientAccessCache.get(key)!;
         }
 
-            const [existingRoleClient] = await transaction
+        const [existingRoleClient] = await trx
             .select()
             .from(roleClients)
             .where(
@@ -199,7 +189,7 @@ export async function calculateUserClientsForOrgs(
             return userClientAccessCache.get(key)!;
         }
 
-            const [existingUserClient] = await transaction
+        const [existingUserClient] = await trx
             .select()
             .from(userClients)
             .where(
@@ -217,7 +207,7 @@ export async function calculateUserClientsForOrgs(
     };
 
     // Get all OLMs for this user
-        const userOlms = await transaction
+    const userOlms = await trx
         .select()
         .from(olms)
         .where(eq(olms.userId, userId));
@@ -226,7 +216,7 @@ export async function calculateUserClientsForOrgs(
         // No OLMs for this user, but we should still clean up any orphaned clients
         await cleanupOrphanedClients(
             userId,
-                transaction,
+            trx,
             [],
             queuedAssociationRebuilds
         );
@@ -234,7 +224,7 @@ export async function calculateUserClientsForOrgs(
     }
 
     // Get all user orgs with all roles (for org list and role-based logic)
-        const userOrgRoleRows = await transaction
+    const userOrgRoleRows = await trx
         .select()
         .from(userOrgs)
         .innerJoin(
@@ -250,10 +240,7 @@ export async function calculateUserClientsForOrgs(
     const userOrgIds = [
         ...new Set(userOrgRoleRows.map((r) => r.userOrgs.orgId))
     ];
-        const orgIdToRoleRows = new Map<
+    const orgIdToRoleRows = new Map<string, (typeof userOrgRoleRows)[0][]>();
-            string,
-            (typeof userOrgRoleRows)[0][]
-        >();
     for (const r of userOrgRoleRows) {
         const list = orgIdToRoleRows.get(r.userOrgs.orgId) ?? [];
         list.push(r);
@@ -300,10 +287,7 @@ export async function calculateUserClientsForOrgs(
             }
 
             // Check if a client already exists for this OLM+user+org combination
-                const existingClient = await getExistingClient(
+            const existingClient = await getExistingClient(orgId, olm.olmId);
-                    orgId,
-                    olm.olmId
-                );
 
             if (existingClient) {
                 // Ensure admin role has access to the client
@@ -313,7 +297,7 @@ export async function calculateUserClientsForOrgs(
                 );
 
                 if (!hasRoleAccess) {
-                        await transaction.insert(roleClients).values({
+                    await trx.insert(roleClients).values({
                         roleId: adminRole.roleId,
                         clientId: existingClient.clientId
                     });
@@ -336,7 +320,7 @@ export async function calculateUserClientsForOrgs(
                 );
 
                 if (!hasUserAccess) {
-                        await transaction.insert(userClients).values({
+                    await trx.insert(userClients).values({
                         userId,
                         clientId: existingClient.clientId
                     });
@@ -366,13 +350,11 @@ export async function calculateUserClientsForOrgs(
             }
 
             const randomExitNode =
-                    exitNodesList[
+                exitNodesList[Math.floor(Math.random() * exitNodesList.length)];
-                        Math.floor(Math.random() * exitNodesList.length)
-                    ];
 
             // Get next available subnet
             const { value: newSubnet, release: releaseSubnetLock } =
-                    await getNextAvailableClientSubnet(orgId, transaction);
+                await getNextAvailableClientSubnet(orgId, trx);
 
             const subnet = newSubnet.split("/")[0];
             const updatedSubnet = `${subnet}/${org.subnet.split("/")[1]}`;
@@ -398,19 +380,16 @@ export async function calculateUserClientsForOrgs(
             };
 
             // Create the client
-                const [newClient] = await transaction
+            const [newClient] = await trx
                 .insert(clients)
                 .values(newClientData)
                 .returning();
             await releaseSubnetLock();
-                existingClientCache.set(
+            existingClientCache.set(getOrgOlmKey(orgId, olm.olmId), newClient);
-                    getOrgOlmKey(orgId, olm.olmId),
-                    newClient
-                );
 
             // create approval request
             if (requireApproval) {
-                    await transaction
+                await trx
                     .insert(approvals)
                     .values({
                         timestamp: Math.floor(new Date().getTime() / 1000),
@@ -425,7 +404,7 @@ export async function calculateUserClientsForOrgs(
             queuedAssociationRebuilds.push(newClient);
 
             // Grant admin role access to the client
-                await transaction.insert(roleClients).values({
+            await trx.insert(roleClients).values({
                 roleId: adminRole.roleId,
                 clientId: newClient.clientId
             });
@@ -435,7 +414,7 @@ export async function calculateUserClientsForOrgs(
             );
 
             // Grant user access to the client
-                await transaction.insert(userClients).values({
+            await trx.insert(userClients).values({
                 userId,
                 clientId: newClient.clientId
             });
@@ -453,11 +432,10 @@ export async function calculateUserClientsForOrgs(
     // Clean up clients in orgs the user is no longer in
     await cleanupOrphanedClients(
         userId,
-            transaction,
+        trx,
         userOrgIds,
         queuedAssociationRebuilds
     );
-    };
 
     runQueuedClientAssociationRebuilds(userId, queuedAssociationRebuilds);
 }
@@ -496,7 +474,7 @@ async function cleanupOrphanedClients(
             )
             .returning();
 
-        // Queue deleted clients for post-transaction association cleanup.
+        // Queue deleted clients for post-trx association cleanup.
         for (const deletedClient of deletedClients) {
             queuedAssociationRebuilds.push(deletedClient);