mirror of
https://github.com/fosrl/pangolin.git
synced 2026-09-16 23:59:53 +02:00
Parikshith
c19cb706e8
Address review feedback on the readiness step: - Read the PID safely (`cat app.pid 2>/dev/null || true`) and treat a missing/empty PID as "not running", so a failed nohup no longer produces a confusing `kill` usage error and misleading message. - Guard the diagnostic dump behind a helper so a missing app.log prints "(app.log not found)" instead of erroring. - The exact 24.18.1 pin comes from the Dockerfiles; .nvmrc only pins the 24 major. Corrected the comments to say so rather than citing .nvmrc as the source of the patch version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
42 lines
1.1 KiB
YAML
42 lines
1.1 KiB
YAML
name: ESLint
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- '**/*.js'
|
|
- '**/*.jsx'
|
|
- '**/*.ts'
|
|
- '**/*.tsx'
|
|
- '.eslintrc*'
|
|
- 'package.json'
|
|
- 'yarn.lock'
|
|
- 'pnpm-lock.yaml'
|
|
- 'package-lock.json'
|
|
|
|
jobs:
|
|
Linter:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
|
|
|
- name: Set up Node.js
|
|
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
|
|
with:
|
|
# Match the version the app ships on (Dockerfile /
|
|
# Dockerfile.dev both use 24.18.1) rather than floating
|
|
# to the latest 24.x.
|
|
node-version: '24.18.1'
|
|
|
|
- name: Install dependencies
|
|
run: npm ci
|
|
|
|
- name: Create build file
|
|
run: npm run set:oss
|
|
|
|
- name: Run ESLint
|
|
run: npx eslint . --ext .js,.jsx,.ts,.tsx
|