calvin.erfmann/TagStudio
1
0
Fork 0
mirror of https://github.com/TagStudioDev/TagStudio.git synced 2026-02-11 20:29:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add loop cutoff to get_tag_categories() (#1075)

Browse Source
This commit is contained in:
Travis Abendshien
2025-08-31 14:00:39 -07:00
committed by GitHub
parent 9891caca35
commit dcf564e8c3
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/tagstudio/qt/widgets/preview/field_containers.py
View File

@@ -168,9 +168,11 @@ class FieldContainers(QWidget):
"Character" -> "Johnny Bravo",
"TV" -> Johnny Bravo"
"""
hierarchy_tags = self.lib.get_tag_hierarchy(t.id for t in tags)
loop_cutoff = 1024 # Used for stopping the while loop
hierarchy_tags = self.lib.get_tag_hierarchy(t.id for t in tags)
categories: dict[Tag | None, set[Tag]] = {None: set()}
for tag in hierarchy_tags.values():
if tag.is_category:
categories[tag] = set()
@@ -178,7 +180,15 @@ class FieldContainers(QWidget):
tag = hierarchy_tags[tag.id]
has_category_parent = False
parent_tags = tag.parent_tags
loop_counter = 0
while len(parent_tags) > 0:
# NOTE: This is for preventing infinite loops in the event a tag is parented
# to itself cyclically.
loop_counter += 1
if loop_counter >= loop_cutoff:
break
grandparent_tags: set[Tag] = set()
for parent_tag in parent_tags:
if parent_tag in categories:
@@ -186,6 +196,7 @@ class FieldContainers(QWidget):
has_category_parent = True
grandparent_tags.update(parent_tag.parent_tags)
parent_tags = grandparent_tags
if tag.is_category:
categories[tag].add(tag)
elif not has_category_parent: